Re: [PATCH v3] irqchip/gic-v2m: Fix refcount leak in gicv2m_of_init
From: Marc Zyngier
Date: Tue Aug 20 2024 - 05:55:12 EST
On Tue, 20 Aug 2024 10:28:43 +0100,
Ma Ke <make24@xxxxxxxxxxx> wrote:
>
> We fail to perform an of_node_put() when of_address_to_resource()
> fails, leading to a refcount leak.
>
> Address this by moving the error handling path outside of the loop and
> making it common to all failure modes.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 4266ab1a8ff5 ("irqchip/gic-v2m: Refactor to prepare for ACPI support")
> Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>
Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx>
M.
--
Without deviation from the norm, progress is not possible.