Re: [PATCH v3 1/2] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters

From: Heiko Stübner
Date: Tue Aug 20 2024 - 06:01:34 EST


Am Montag, 19. August 2024, 10:02:22 CEST schrieb Mary Guillemard:
> Expose system timestamp and frequency supported by the GPU.
>
> Mali uses an external timer as GPU system time. On ARM, this is wired to
> the generic arch timer so we wire cntfrq_el0 as device frequency.
>
> This new uAPI will be used in Mesa to implement timestamp queries and
> VK_KHR_calibrated_timestamps.
>
> v2:
> - Rewrote to use GPU timestamp register
> - Add missing include for arch_timer_get_cntfrq
> - Rework commit message
>
> v3:
> - Move panfrost_cycle_counter_get and panfrost_cycle_counter_put to
> panfrost_ioctl_query_timestamp
> - Handle possible overflow in panfrost_timestamp_read
>
> Signed-off-by: Mary Guillemard <mary.guillemard@xxxxxxxxxxxxx>


On a rk3588-tiger with matching MESA build and
"RUSTICL_ENABLE=panfrost clpeak"

Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>

Without this change, clpeak fails with
clCreateCommandQueue (-35)