Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

From: Andy Shevchenko
Date: Tue Aug 20 2024 - 06:16:32 EST


On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote:
> Simplify driver error paths by adding devm_typec_switch_register() which
> will unregister the typec switch when the parent device is unbound.

> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: <linux-usb@xxxxxxxxxxxxxxx>
> Cc: Pin-yen Lin <treapking@xxxxxxxxxxxx>

As per previous patches.

...

> + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr), GFP_KERNEL);
> + if (!ptr)
> + return ERR_PTR(-ENOMEM);
> +
> + switch_dev = typec_switch_register(parent ,desc);
> + if (!IS_ERR(switch_dev)) {
> + *ptr = switch_dev;
> + devres_add(parent, ptr);
> + } else {
> + devres_free(ptr);
> + }

devm_add_action_or_reset() ?

--
With Best Regards,
Andy Shevchenko