Re: [PATCH] netfilter: nfnetlink_log: remove unnecessary check in __build_packet_message()

From: Pablo Neira Ayuso
Date: Tue Aug 20 2024 - 07:26:10 EST


On Fri, Aug 09, 2024 at 10:40:35AM +0300, Roman Smirnov wrote:
> skb->dev is always non-NULL, the check is unnecessary.

Same check exists in nfnetlink_queue, these two codebases have many
similarities.

I cannot think of any scenario where skb->dev is NULL in any of the
existing hooks.