Re: [PATCH net-next] nfc: st95hf: switch to using sleeping variants of gpiod API

From: Andrew Lunn
Date: Tue Aug 20 2024 - 09:53:32 EST


On Tue, Aug 20, 2024 at 10:10:37AM +0200, Przemek Kitszel wrote:
> On 8/20/24 03:10, Dmitry Torokhov wrote:
> > The driver does not not use gpiod API calls in an atomic context. Switch
>
> please remove one "not"
>
> > to gpiod_set_value_cansleep() calls to allow using the driver with GPIO
> > controllers that might need process context to operate.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> Code is fine, but why not as a fix?

Why would this be a fix? What is broken?

Andrew