Re: [PATCH net-next v2 2/3] ethtool: Add support for specifying information source in cable test results

[Andrew Lunn]

On Tue, Aug 20, 2024 at 12:12:55PM +0200, Oleksij Rempel wrote:
> Enhance the ethtool cable test interface by introducing the ability to
> specify the source of the diagnostic information for cable test results.
> This is particularly useful for PHYs that offer multiple diagnostic
> methods, such as Time Domain Reflectometry (TDR) and Active Link Cable
> Diagnostic (ALCD).
> 
> Key changes:
> - Added `ethnl_cable_test_result_with_src` and
>   `ethnl_cable_test_fault_length_with_src` functions to allow specifying
>   the information source when reporting cable test results.
> - Updated existing `ethnl_cable_test_result` and
>   `ethnl_cable_test_fault_length` functions to use TDR as the default
>   source, ensuring backward compatibility.
> - Modified the UAPI to support these new attributes, enabling drivers to
>   provide more detailed diagnostic information.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew