Re: [PATCH] sched_ext: Allow dequeue_task_scx to fail
From: Tejun Heo
Date: Tue Aug 20 2024 - 15:09:47 EST
On Tue, Aug 20, 2024 at 10:45:31AM +0800, Yipeng Zou wrote:
> Since dequeue_task() allowed to fail, there is a compile error:
>
> kernel/sched/ext.c:3630:19: error: initialization of ‘bool (*)(struct rq*, struct task_struct *, int)’ {aka ‘_Bool (*)(struct rq *, struct task_struct *, int)’} from incompatible pointer type ‘void (*)(struct rq*, struct task_struct *, int)’
> 3630 | .dequeue_task = dequeue_task_scx,
> | ^~~~~~~~~~~~~~~~
>
> Allow dequeue_task_scx to fail too.
>
> Fixes: 863ccdbb918a ("sched: Allow sched_class::dequeue_task() to fail")
> Signed-off-by: Yipeng Zou <zouyipeng@xxxxxxxxxx>
Applied to sched_ext/for-6.12.
Thanks.
--
tejun