Re: [PATCH v2 1/7] net: driver: stmmac: extend CSR calc support
From: Jacob Keller
Date: Tue Aug 20 2024 - 17:10:21 EST
On 8/18/2024 2:50 PM, Jan Petrous (OSS) wrote:
> Add support for CSR clock range up to 800 MHz.
>
> When in, fix STMMAC_CSR_250_300M divider comment.
>
The phrasing of this was somewhat confusing. I would also have chosen to
do this as a separate fix, since it makes reading the change somewhat
more difficult. A separate change could also explain how it was wrong in
the first place and add more context.
Either way, I think its a minor enough change and it only affects a code
comment. Not a huge deal.
Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>