Re: [PATCH net-next v2 1/3] netpoll: Ensure clean state on setup failures
From: Jakub Kicinski
Date: Tue Aug 20 2024 - 19:20:21 EST
On Mon, 19 Aug 2024 03:36:11 -0700 Breno Leitao wrote:
> + DEBUG_NET_WARN_ON_ONCE(np->dev);
> if (ndev->priv_flags & IFF_DISABLE_NETPOLL) {
> np_err(np, "%s doesn't support polling, aborting\n",
> - np->dev_name);
> + ndev->name);
> err = -ENOTSUPP;
> goto out;
> }
> put:
> + DEBUG_NET_WARN_ON_ONCE(np->dev);
nit: having two warnings feels a bit excessive, let's pick one location?