Re: [PATCH] memory: mtk-smi: Simplify using devm_clk_get_enabled()

From: Rong Qianfeng
Date: Tue Aug 20 2024 - 22:02:38 EST



在 2024/8/20 20:40, Krzysztof Kozlowski 写道:
[Some people who received this message don't often get email from krzk@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On 20/08/2024 14:34, Rong Qianfeng wrote:
devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable()
and the clock will automatically be disabled, unprepared and freed when
the device is unbound from the bus.
That's obvious, drop. You do not have to explain basic APIs. Instead say
what is being simplified here.

So simplify mtk_smi_common_probe()
accordingly.
Also explain that you fix bug of missing unprepare in unbind and add
Fixes+CC stable tags.

OK, thanks for the reminder.

Best regards,

Qianfeng


Best regards,
Krzysztof