RE: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to configure fixed link state in phylink

[Raju.Lakkaraju]

Hi Andrew,

Thank you for review the patch.

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Monday, August 19, 2024 9:39 PM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; linux@xxxxxxxxxxxxxxx;
> kuba@xxxxxxxxxx; horms@xxxxxxxxxx; hkallweit1@xxxxxxxxx;
> richardcochran@xxxxxxxxx; rdunlap@xxxxxxxxxxxxx; Bryan Whitehead -
> C21958 <Bryan.Whitehead@xxxxxxxxxxxxx>; edumazet@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; UNGLinuxDriver
> <UNGLinuxDriver@xxxxxxxxxxxxx>
> Subject: Re: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to
> configure fixed link state in phylink
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> > +/**
> > + * phylink_set_fixed_link() - set the fixed link
> > + * @pl: a pointer to a &struct phylink returned from phylink_create()
> > + * @state: a pointer to a struct phylink_link_state.
> > + *
> > + * This function is used when the link parameters are known and do
> > +not change,
> > + * making it suitable for certain types of network connections.
> > + *
> > + * Returns zero on success, or negative error code.
> 
> kernel doc requires a : after Returns. The tooling is getting more picky about
> this and pointing out this error. But there is a lot of code which gets this
> wrong, so you probably cut/paste a bad example.
> 

Ok. I will fix.
You are correct. I did copy/paste the string.

>     Andrew
> 
> ---
> pw-bot: cr

Thanks,
Raju