RE: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to configure fixed link state in phylink

From: Raju.Lakkaraju
Date: Wed Aug 21 2024 - 04:22:45 EST



Hi Simon,

Thank you for review the patch.

> -----Original Message-----
> From: Simon Horman <horms@xxxxxxxxxx>
> Sent: Monday, August 19, 2024 9:54 PM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; linux@xxxxxxxxxxxxxxx;
> kuba@xxxxxxxxxx; andrew@xxxxxxx; hkallweit1@xxxxxxxxx;
> richardcochran@xxxxxxxxx; rdunlap@xxxxxxxxxxxxx; Bryan Whitehead -
> C21958 <Bryan.Whitehead@xxxxxxxxxxxxx>; edumazet@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; UNGLinuxDriver
> <UNGLinuxDriver@xxxxxxxxxxxxx>
> Subject: Re: [PATCH net-next] net: phylink: Add phylinksetfixed_link() to
> configure fixed link state in phylink
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Mon, Aug 19, 2024 at 10:53:35AM +0530, Raju Lakkaraju wrote:
> > From: Russell King <linux@xxxxxxxxxxxxxxx>
> >
> > The function allows for the configuration of a fixed link state for a
> > given phylink instance. This addition is particularly useful for
> > network devices that operate with a fixed link configuration, where
> > the link parameters do not change dynamically. By using
> > `phylink_set_fixed_link()`, drivers can easily set up the fixed link state during
> initialization or configuration changes.
> >
> > Signed-off-by: Russell King <linux@xxxxxxxxxxxxxxx>
> > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@xxxxxxxxxxxxx>
> > ---
> > Note: This code was developed by Mr.Russell King.
>
> Hi,
>
> I am wondering if we need a user of this function in order for this patch to be
> accepted, as is often the practice for new features.

This patch is Mr. Russell King's developed code which I'm submitting to Linux community for review.
just following Russell's request.
i.e.
https://lore.kernel.org/netdev/ZsCMtARGCOLsbF9h@xxxxxxxxxxxxxxxxxxxxx/

if it is required, I can send both together in a single series. Please confirm

Hi Russell, Do you any concerns about Mr. Simon comments?

Thanks,
Raju