Re: [PATCH 10/11] net: macb: Add support for RP1's MACB variant

[Krzysztof Kozlowski]

On Tue, Aug 20, 2024 at 04:36:12PM +0200, Andrea della Porta wrote:
> RaspberryPi RP1 contains Cadence's MACB core. Implement the
> changes to be able to operate the customization in the RP1.
> 
> Signed-off-by: Andrea della Porta <andrea.porta@xxxxxxxx>


> @@ -5100,6 +5214,11 @@ static int macb_probe(struct platform_device *pdev)
>  			}
>  		}
>  	}
> +
> +	device_property_read_u8(&pdev->dev, "cdns,aw2w-max-pipe", &bp->aw2w_max_pipe);
> +	device_property_read_u8(&pdev->dev, "cdns,ar2r-max-pipe", &bp->ar2r_max_pipe);

Where are the bindings?

> +	bp->use_aw2b_fill = device_property_read_bool(&pdev->dev, "cdns,use-aw2b-fill");
> +
>  	spin_lock_init(&bp->lock);
>  
>  	/* setup capabilities */
> @@ -5155,6 +5274,21 @@ static int macb_probe(struct platform_device *pdev)
>  	else
>  		bp->phy_interface = interface;
>  
> +	/* optional PHY reset-related properties */
> +	bp->phy_reset_gpio = devm_gpiod_get_optional(&pdev->dev, "phy-reset",

Where is the binding?

> +						     GPIOD_OUT_LOW);
> +	if (IS_ERR(bp->phy_reset_gpio)) {
> +		dev_err(&pdev->dev, "Failed to obtain phy-reset gpio\n");
> +		err = PTR_ERR(bp->phy_reset_gpio);
> +		goto err_out_free_netdev;
> +	}
> +
> +	bp->phy_reset_ms = 10;
> +	of_property_read_u32(np, "phy-reset-duration", &bp->phy_reset_ms);

Where is the binding?

> +	/* A sane reset duration should not be longer than 1s */
> +	if (bp->phy_reset_ms > 1000)
> +		bp->phy_reset_ms = 1000;
> +
>  	/* IP specific init */
>  	err = init(pdev);

Best regards,
Krzysztof