Re: [PATCH v2] mailbox: sprd: Use devm_clk_get_enabled() helpers

[Christophe JAILLET]

Le 21/08/2024 à 09:08, Huan Yang a écrit :
> 在 2024/8/21 15:00, Christophe JAILLET 写道:
> > Le 21/08/2024 à 03:39, Huan Yang a écrit :
> > > The devm_clk_get_enabled() helpers:
> > >       - call devm_clk_get()
> > >       - call clk_prepare_enable() and register what is needed in 
> > > order to
> > >        call clk_disable_unprepare() when needed, as a managed resource.
> > >
> > > This simplifies the code and avoids the calls to 
> > > clk_disable_unprepare().
> > >
> > > Due to clk only used in probe, not in suspend\resume, this pointer can
> > > remove from sprd_mbox_priv to save a little memory.
> > >
> > > Signed-off-by: Huan Yang <link@xxxxxxxx>
> > > Suggested-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> >
> >
> > Nitpick: no need to add this S-b. I just made a comment when looking 
> > at your patch in order to improve it. I'm not the one that suggested 
> > the initial change. All merit is yours.
> Your suggestion is helpfull, help this patch be better.
> > Also, I think that, if used, it should be above your Signed-off.
> Hmmm, it's neccessary? If so, I'd like to update it.

I don't think it is useful and personally I would remove it, but you can 
keep it if it makes sense to you.

CJ