Re: [PATCH v3 03/14] thermal: core: Drop redundant thermal instance checks

[Daniel Lezcano]

On 21/08/2024 13:11, Rafael J. Wysocki wrote:
> On Wed, Aug 21, 2024 at 1:01 PM Daniel Lezcano
> <daniel.lezcano@xxxxxxxxxx> wrote:
> > On 19/08/2024 17:52, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > >
> > > Because the trip and cdev pointers are sufficient to identify a thermal
> > > instance holding them unambiguously, drop the additional thermal zone
> > > checks from two loops walking the list of thermal instances in a
> > > thermal zone.
> > >
> > > No intentional functional impact.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > Reviewed-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> >
> > I'm wondering if the thermal_instance 'tz' field could be removed too ?
>
> It is used in a debug printk in __thermal_cdev_update().  If that
> message can be dropped, then yes, but that would be a separate patch
> anyway.

Yes, I don't think it is really worth the debug message here


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog