Re: [PATCH 4/6] Staging: rtl8192e: Rename variable CmdID_WritePortUlong

From: Dan Carpenter
Date: Wed Aug 21 2024 - 08:41:54 EST


On Tue, Aug 20, 2024 at 08:08:54PM -0700, Tree Davies wrote:
> Rename variable CmdID_WritePortUlong to cmd_id_write_port_ulong
> to fix checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Tree Davies <tdavies@xxxxxxxxxxxxxxx>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +-
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> index e82e992dd139..8a1aac7e10a2 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> @@ -616,7 +616,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
> _rtl92e_set_tx_power_level(dev,
> channel);
> break;
> - case CmdID_WritePortUlong:
> + case cmd_id_write_port_ulong:
> rtl92e_writel(dev, CurrentCmd->Para1,
> CurrentCmd->Para2);

I'm not a historian. I know that writel() writes a u32 value for historical
reasons. But I feel like it's unexpected to create a write ulong which writes
a u32.

regards,
dan carpenter