Re: [PATCH 00/31] wifi: mwifiex: cleanup driver

From: Kalle Valo
Date: Wed Aug 21 2024 - 10:07:25 EST


Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes:

> On Tue, Aug 20, 2024 at 08:42:38PM +0300, Kalle Valo wrote:
>> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes:
>>
>> > This series has a bunch of cleanup and bugfix patches for the mwifiex
>> > driver.
>> >
>>
>> [...]
>>
>> > ---
>> > Sascha Hauer (31):
>>
>> BTW 30 patches is a lot to review. A good rule of thumb is to have max
>> 12 patches per patchset, maybe a bit more if the patches are small.
>> Splitting this into two patchsets would make it a lot more pleasent for
>> the reviewers.
>
> Ok, I'll split up this series into smaller chunks. Be prepared there are
> more to come

Awesome, keep them coming!

> this driver is really full of cruft...

Honestly I have not not looked at the driver in detail but that's what
everyone are saying. So I appreciate you doing this. And I wish NXP
would help you in the effort, this a great way to learn how things work
in upstream.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches