Re: [PATCH v2] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals Support

[Marc Kleine-Budde]

On 21.08.2024 19:28:17, Tarang Raval wrote:
> Add following peripherals support for the Emtop i.MX8M Mini Baseboard
> 
>     * Wi-Fi
>     * Audio
>     * SD card
>     * RTC
>     * CAN bus
>     * USB OTG
> 
> Signed-off-by: Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>
> ---
> 
> Changes in v2:
> 
> 1. Updated the node name and pinctrl name
> 2. Removed the 'regulators' container
> 3. Removed a stray blank line
> 4. Removed non-existent properties
> 5. Removed unused node and pinctrl
>    - modem-reset
>    - pinctrl_uart1
> 6. Defined the CAN transceiver reset GPIO separately
> ---
>  .../dts/freescale/imx8mm-emtop-baseboard.dts  | 323 ++++++++++++++++++
>  1 file changed, 323 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
> index 7d2cb74c64ee..322338e626ce 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts
> @@ -11,6 +11,113 @@ / {

[...]

> +	can-control {
> +	        pinctrl-names = "default";
> +	        pinctrl-0 = <&pinctrl_cancontrol>;
> +	        reset-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;

I don't see a compatible here.

[...]

> +/* CAN BUS */
> +&ecspi2 {
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_ecspi2>;
> +        status = "okay";
> +
> +        can: can@0 {
> +                compatible = "microchip,mcp2515";
> +                pinctrl-names = "default";
> +                pinctrl-0 = <&pinctrl_canbus>;
> +                reg = <0>;
> +                clocks = <&osc_can>;
> +                interrupt-parent = <&gpio1>;
> +                interrupts = <14 IRQ_TYPE_EDGE_FALLING>;

Don't use edge triggered interrupts, use level triggered ones.

> +                spi-max-frequency = <10000000>;
> +        };
>  };

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature