Re: [PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List

[Andy Shevchenko]

On Wed, Aug 21, 2024 at 06:39:04PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 21, 2024 at 08:42:12PM +0530, Shyam Sundar S K wrote:
> > On 8/21/2024 19:26, Andy Shevchenko wrote:
> > > On Wed, Aug 21, 2024 at 07:07:45PM +0530, Shyam Sundar S K wrote:
> > >> On 8/21/2024 19:05, Shyam Sundar S K wrote:

...

> > >>> This update adds the AMDI5017 ACPI ID to the list of supported IDs.
> 
> s/This update adds/Add/
> 
> > > Please, provide a DSDT excerpt to show how it will look like in the ACPI
> > > tables.
> > 
> >     Scope (_SB)
> >     {
> > 	...
> > 
> >         Name (HCID, "AMDI5017")
> >         Device (I3CA)
> >         {
> >             Method (_HID, 0, Serialized)  // _HID: Hardware ID
> >             {
> >                 If ((I30M == Zero))
> >                 {
> >                     If (CondRefOf (HCIB))
> >                     {
> >                         Return (HCID) /* \_SB_.HCID */
> >                     }
> >                     Else
> >                     {
> >                         Return (I3ID) /* \_SB_.I3ID */
> 
> Do I understand correctly that I3ID is the old one (as per another path I have
> seen last week or so), i.o.w. *not* a MIPI allocated one?
> 
> If it's the case, feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> from ACPI ID perspective.

Regarding MIPI ID and using it as a _CID is kinda unsolved now, in any case
_CID *requires* _HID to be present, and hence _HID has a priority in
enumeration. It doesn't matter if it's absent now (it's even more flexible in
case MIPI decides to use _another_ ID for _CID) as long as software uses
_HID for enumeration.

> >                     }
> >                 }
> >                 Else
> >                 {
> >                     Return (I2ID) /* \_SB_.I2ID */
> >                 }
> >             }
> > 	
> > 	...
> >     }

-- 
With Best Regards,
Andy Shevchenko