Re: [PATCH iwl-net v3 1/6] ice: move netif_queue_set_napi to rtnl-protected sections

From: Tony Nguyen
Date: Wed Aug 21 2024 - 17:21:06 EST


On 8/20/2024 6:26 AM, Maciej Fijalkowski wrote:

...

Fixes: 080b0c8d6d26 ("ice: Fix ASSERT_RTNL() warning during certain scenarios")

Shouldn't you include:
Fixes: 91fdbce7e8d6 ("ice: Add support in the driver for associating queue with napi")

as we were iterating over XDP rings that were attached to q_vectors from
the very beginning?


I probably should have done this.

Maybe this could be included while applying or sending the pull request by
Tony. I'll go through the rest of set today to see if I have any comments,
if there won't be anything outstanding then it won't make sense to send
next revision just to fix the fixes tags.

Yes, I can add that in.

Thanks,
Tony