Re: [PATCH] drm/panel/hx83102: fix null pointer dereference in hx83102_get_modes

From: Greg KH
Date: Wed Aug 21 2024 - 19:46:02 EST


On Wed, Aug 21, 2024 at 05:50:39PM +0800, Charles Han wrote:
> From: hanchunchao <hanchunchao@xxxxxxxxxx>

Nit, this should be your name, not your email alias here, like you have
it on your "From" line.

> In hx83102_get_modes(), the return value of drm_mode_duplicate() is
> assigned to mode, which will lead to a possible NULL pointer dereference
> on failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Signed-off-by: hanchunchao <hanchunchao@xxxxxxxxxx>

Same here.

What commit id does this fix? Shouldn't you also cc: stable to get it
backported?

And there's no need to cc: security@xxxxxxxxxx, as this is a public
issue and you have a patch for it.

thanks,

greg k-h