Re: [PATCH v2 16/16] overlayfs: Remove ovl_override_creds_light()

From: Miklos Szeredi
Date: Thu Aug 22 2024 - 05:00:17 EST


On Thu, 22 Aug 2024 at 03:25, Vinicius Costa Gomes
<vinicius.gomes@xxxxxxxxx> wrote:
>
> Remove the declaration of this unsafe helper.
>
> As the GUARD() helper guarantees that the cleanup will run, it is less
> error prone.

This statement is somewhat dubious.

I suggest that unless and until the goto issue can be fixed the
conversion to guards is postponed.

Thanks,
Miklos