Re: [PATCH v1] drivers:ras:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
From: Jonathan Cameron
Date: Thu Aug 22 2024 - 05:05:23 EST
On Wed, 21 Aug 2024 03:17:18 -0400
Yang Ruibin <11162571@xxxxxxxx> wrote:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
>
> Signed-off-by: Yang Ruibin <11162571@xxxxxxxx>
Ideally needs a fixes tag.
Otherwise (given I looked into a similar one last night
with the same pattern).
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
> drivers/ras/cec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index e440b15fbabc..ebd4631b685b 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
> }
>
> d = debugfs_create_dir("cec", dfs);
> - if (!d) {
> + if (IS_ERR(d)) {
> pr_warn("Error creating cec debugfs node!\n");
> return -1;
> }