Re: [PATCH v1] drivers:atlx:Use max macro

From: Yang Ruibin
Date: Thu Aug 22 2024 - 05:45:23 EST


Sorry, please ignore this patch.
Because the corresponding header file is not included, there may be compilation errors.

在 2024/8/22 15:50, Yang Ruibin 写道:
Instead of using the max() implementation of
the ternary operator, use real macros.

Signed-off-by: Yang Ruibin <11162571@xxxxxxxx>
---
drivers/net/ethernet/atheros/atlx/atl2.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
index fa9a4919f..3ff669e72 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -2971,10 +2971,7 @@ static void atl2_check_options(struct atl2_adapter *adapter)
#endif
/* init RXD Flow control value */
adapter->hw.fc_rxd_hi = (adapter->rxd_ring_size / 8) * 7;
- adapter->hw.fc_rxd_lo = (ATL2_MIN_RXD_COUNT / 8) >
- (adapter->rxd_ring_size / 12) ? (ATL2_MIN_RXD_COUNT / 8) :
- (adapter->rxd_ring_size / 12);
-
+ adapter->hw.fc_rxd_lo = max(ATL2_MIN_RXD_COUNT / 8, adapter->rxd_ring_size / 12);
/* Interrupt Moderate Timer */
opt.type = range_option;
opt.name = "Interrupt Moderate Timer";