Re: [PATCH 3/4] arm64: dts: qcom: ipq5332: add nodes to bringup q6

[Gokul Sriram P]

On 8/20/2024 4:51 PM, Krzysztof Kozlowski wrote:
> On Tue, Aug 20, 2024 at 02:25:16PM +0530, Gokul Sriram Palanisamy wrote:
> > From: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> >
> > Enable nodes required for q6 remoteproc bring up.
> >
> > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> > Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 62 +++++++++++++++++++++++++++
> >   1 file changed, 62 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > index 0a74ed4f72cc..ec93e7b64b9e 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> > @@ -145,6 +145,11 @@ smem@4a800000 {
> >   
> >   			hwlocks = <&tcsr_mutex 3>;
> >   		};
> > +
> > +		q6_region: wcnss@4a900000 {
> Why here it is wcnss...
will change it to wcss.
> > +			reg = <0x0 0x4a900000 0x0 0x2b00000>;
> > +			no-map;
> > +		};
> >   	};
> >   
> >   	soc@0 {
> > @@ -476,6 +481,39 @@ frame@b128000 {
> >   				status = "disabled";
> >   			};
> >   		};
> > +
> > +		q6v5_wcss: remoteproc@d100000 {
> but everywhere else is wcss?
yes, will stick to wcss everywhere.
> > +			compatible = "qcom,ipq5332-wcss-sec-pil";
> > +			reg = <0xd100000 0x4040>;
> > +			firmware-name = "ath12k/IPQ5332/hw1.0/q6_fw0.mdt";
> It's one firmware independent of board?

Yes, we have only one firmware across all our boards.

Regards,

Gokul

> Best regards,
> Krzysztof