Re: [PATCH v1] driver:net:et131x:Remove NULL check of list_entry()

[Mark Einon]

On Thu, 2024-08-22 at 11:05 +0800, Yuesong Li wrote:
> list_entry() will never return a NULL pointer, thus remove the
> check.
> 
> Signed-off-by: Yuesong Li <liyuesong@xxxxxxxx>

Reviewed-by: Mark Einon <mark.einon@xxxxxxxxx>

Thanks,

Mark

> ---
>  drivers/net/ethernet/agere/et131x.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/agere/et131x.c
> b/drivers/net/ethernet/agere/et131x.c
> index b325e0cef120..74fc55b9f0d9 100644
> --- a/drivers/net/ethernet/agere/et131x.c
> +++ b/drivers/net/ethernet/agere/et131x.c
> @@ -2244,11 +2244,6 @@ static struct rfd *nic_rx_pkts(struct
> et131x_adapter *adapter)
>  	element = rx_local->recv_list.next;
>  	rfd = list_entry(element, struct rfd, list_node);
>  
> -	if (!rfd) {
> -		spin_unlock_irqrestore(&adapter->rcv_lock, flags);
> -		return NULL;
> -	}
> -
>  	list_del(&rfd->list_node);
>  	rx_local->num_ready_recv--;
>