Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL

From: Krzysztof Kozlowski
Date: Thu Aug 22 2024 - 07:31:17 EST


On 22/08/2024 12:47, Gokul Sriram P wrote:
>>> +
>>> + interrupts:
>>> + items:
>>> + - description: Watchdog interrupt
>>> + - description: Fatal interrupt
>>> + - description: Ready interrupt
>>> + - description: Handover interrupt
>>> + - description: Stop acknowledge interrupt
>>> +
>>> + interrupt-names:
>>> + items:
>>> + - const: wdog
>>> + - const: fatal
>>> + - const: ready
>>> + - const: handover
>>> + - const: stop-ack
>>> +
>>> + clocks:
>>> + items:
>>> + - description: IM SLEEP clock
>> What is IM? Explain all acronyms.
>>
>> What is SLEEP?
>
> IM_SLEEP_CLK - Internal Module sleep clock needed for Q6 reset.
>
> SLEEP is not an acronym here.

Then probably you mean "Internal sleep", although "internal" is also
confusing. Devices do not receive as input something which is internal
to them.

>
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: im_sleep
>> sleep? Are there different sleep clocks here?
>
> We have different branches of sleep clk each enabled separately.
>
> im_sleep is one of those branches that q6 uses.

So this device misses other branches? Then provide them. Otherwise it is
just "sleep".



Best regards,
Krzysztof