RE: [Intel-wired-lan] [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for 82580

[Pucha, HimasekharX Reddy]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Daiwei Li
> Sent: Wednesday, August 14, 2024 10:26 AM
> To: intel-wired-lan@xxxxxxxxxxxxxxxx
> Cc: Daiwei Li <daiweili@xxxxxxxxxx>; Neftin, Sasha <sasha.neftin@xxxxxxxxx>; Gomes, Vinicius <vinicius.gomes@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; richardcochran@xxxxxxxxx; kurt@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; edumazet@xxxxxxxxxx; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; davem@xxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for 82580
>
> 82580 NICs have a hardware bug that makes it necessary to write into the TSICR (TimeSync Interrupt Cause) register to clear it:
> https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@xxxxxxxxx/
>
> Add a conditional so only for 82580 we write into the TSICR register, so we don't risk losing events for other models.
>
> Without this change, when running ptp4l with an Intel 82580 card, I get the following output:
>
> > timed out while polling for tx timestamp increasing 
> > tx_timestamp_timeout or increasing kworker priority may correct this 
> > issue, but a driver bug likely causes it
>
> This goes away with this change.
>
> This (partially) reverts commit ee14cc9ea19b ("igb: Fix missing time sync events").
>
> Fixes: ee14cc9ea19b ("igb: Fix missing time sync events")
> Closes: https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w@xxxxxxxxxxxxxx/
> Tested-by: Daiwei Li <daiweili@xxxxxxxxxx>
> Suggested-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>
> Signed-off-by: Daiwei Li <daiweili@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@xxxxxxxxx> (A Contingent worker at Intel)