Re: [PATCH] x86/MCE: Prevent CPU offline for SMCA CPUs with non-core banks

From: Yazen Ghannam
Date: Thu Aug 22 2024 - 10:14:46 EST


On Wed, Aug 21, 2024 at 02:35:23PM -0400, boris.ostrovsky@xxxxxxxxxx wrote:
>
>
> On 8/21/24 10:00 AM, Yazen Ghannam wrote:
>
> > + if (!mce_cpu_is_hotpluggable()) {
> > + pr_info("CPU%d is not hotpluggable\n", cpu);
>
> Can this error message be made a little more informative, e.g. that it is
> emitted from MCA code? And is info the right level? I think notice would be
> more appropriate.
>

Sure thing. I can change the level to notice.

The MCE subsystem has a global prefix set already by pr_fmt. This is
defined in arch/x86/kernel/cpu/mce/internal.h.

Thanks,
Yazen