Re: [PATCHv2] net: dpaa:reduce number of synchronize_net() calls

[Jakub Kicinski]

On Thu, 22 Aug 2024 15:20:42 +0800 Xi Huang wrote:
> In the function dpaa_napi_del(), we execute the netif_napi_del()
> for each cpu, which is actually a high overhead operation
> because each call to netif_napi_del() contains a synchronize_net(),
> i.e. an RCU operation. In fact, it is only necessary to call
>  __netif_napi_del and use synchronize_net() once outside of the loop.
> This change is similar to commit 2543a6000e593a ("gro_cells: reduce
> number of synchronize_net() calls") and commit 5198d545dba8ad (" net:
> remove napi_hash_del() from driver-facing API") 5198d545db.
> 
> Signed-off-by: Xi Huang <xuiagnh@xxxxxxxxx>
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

You missed the part of Eric's response that told you to wait 24 hours:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
-- 
pv-bot: 24h