Re: [PATCH net-next v3 3/3] phy: dp83tg720: Add statistics support

From: Andrew Lunn
Date: Thu Aug 22 2024 - 11:50:29 EST


On Thu, Aug 22, 2024 at 01:59:39PM +0200, Oleksij Rempel wrote:
> Introduce statistics support for the DP83TG720 PHY driver, enabling
> detailed monitoring and reporting of link quality and packet-related
> metrics.
>
> To avoid double reading of certain registers, the implementation caches
> all relevant register values in a single operation. This approach
> ensures accurate and consistent data retrieval, particularly for
> registers that clear upon reading or require special handling.
>
> Some of the statistics, such as link training times, do not increment
> and therefore require special handling during the extraction process.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew