Re: [PATCH 1/3] thermal: of: Fix OF node leak in thermal_of_trips_init() error path

[Daniel Lezcano]

On 22/08/2024 17:54, Rafael J. Wysocki wrote:
> On Mon, Aug 19, 2024 at 3:31 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> > On Mon, Aug 19, 2024 at 3:22 PM Daniel Lezcano
> > <daniel.lezcano@xxxxxxxxxx> wrote:
> > > On 19/08/2024 15:20, Rafael J. Wysocki wrote:
> > > > On Mon, Aug 19, 2024 at 12:12 PM Daniel Lezcano
> > > > <daniel.lezcano@xxxxxxxxxx> wrote:
> > > > > On 14/08/2024 21:58, Krzysztof Kozlowski wrote:
> > > > > > Terminating for_each_child_of_node() loop requires dropping OF node
> > > > > > reference, so bailing out after thermal_of_populate_trip() error misses
> > > > > > this.  Solve the OF node reference leak with scoped
> > > > > > for_each_child_of_node_scoped().
> > > > > >
> > > > > > Fixes: d0c75fa2c17f ("thermal/of: Initialize trip points separately")
> > > > > > Cc: <stable@xxxxxxxxxxxxxxx>
> > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > > > > > ---
> > > > >
> > > > > Applied, thanks for the fixes
> > > >
> > > > Is there a place from which I can pull these?
> > > >
> > > > It would be good to include them into 6.11 as they are -stable material.
> > > >
> > > > Alternatively, I can pick them up from the list.
> > >
> > > I'll send a PR for fixes only. Let me double check if there are other
> > > fixes to go along with those
> >
> > Sure, thanks!
>
> Sorry for pressing, but it would be good to get this material into -rc5.
>
> I can still pick up the patches, I don't believe they are controversial.

Ok, feel free to pick them. Give me a few minutes to add my tags

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog