Re: [PATCH V3 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

[Andrew Lunn]

> +void hbg_phy_start(struct hbg_priv *priv)
> +{
> +	if (!priv->mac.phydev)
> +		return;
> +
> +	phy_start(priv->mac.phydev);
> +}
> +
> +void hbg_phy_stop(struct hbg_priv *priv)
> +{
> +	if (!priv->mac.phydev)
> +		return;
> +
> +	phy_stop(priv->mac.phydev);

Can this condition priv->mac.phydev not be true? The mdio bus setup
and connecting to the PHY seems to be unconditional. If it fails, the
driver fails to probe.

	Andrew