[PATCH v1 1/2] clk: x86: lpss-atom: Use predefined constants from units.h
From: Andy Shevchenko
Date: Thu Aug 22 2024 - 12:15:36 EST
Use predefined constants from units.h to make code robust against typos
like how many zeros to put.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/clk/x86/clk-lpss-atom.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/x86/clk-lpss-atom.c b/drivers/clk/x86/clk-lpss-atom.c
index aa9d0bb98f8b..c70088be72d1 100644
--- a/drivers/clk/x86/clk-lpss-atom.c
+++ b/drivers/clk/x86/clk-lpss-atom.c
@@ -12,20 +12,24 @@
#include <linux/module.h>
#include <linux/platform_data/x86/clk-lpss.h>
#include <linux/platform_device.h>
+#include <linux/units.h>
static int lpss_atom_clk_probe(struct platform_device *pdev)
{
struct lpss_clk_data *drvdata;
struct clk *clk;
+ u32 rate;
drvdata = devm_kzalloc(&pdev->dev, sizeof(*drvdata), GFP_KERNEL);
if (!drvdata)
return -ENOMEM;
+ /* Default frequency is 100MHz */
+ rate = 100 * HZ_PER_MHZ;
+
/* LPSS free running clock */
drvdata->name = "lpss_clk";
- clk = clk_register_fixed_rate(&pdev->dev, drvdata->name, NULL,
- 0, 100000000);
+ clk = clk_register_fixed_rate(&pdev->dev, drvdata->name, NULL, 0, rate);
if (IS_ERR(clk))
return PTR_ERR(clk);
--
2.43.0.rc1.1336.g36b5255a03ac