Re: [PATCH][next] wifi: ath12k: Avoid -Wflex-array-member-not-at-end warnings

[Jeff Johnson]

On 8/22/2024 9:51 AM, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx> wrote:
> 
>> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are
>> getting ready to enable it, globally.
>>
>> Move the conflicting declaration to the end of the structure. Notice
>> that `struct ieee80211_chanctx_conf` is a flexible structure --a
>> structure that contains a flexible-array member.
>>
>> Also, remove an unused structure.
>>
>> Fix the following warnings:
>> drivers/net/wireless/ath/ath12k/core.h:290:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
>> drivers/net/wireless/ath/ath12k/dp.h:1499:24: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>
> 
> Should I add a similar comment as with the ath11k patch:
> 
> https://patchwork.kernel.org/project/linux-wireless/patch/ZrZB3Rjswe0ZXtug@cute/
> 

Sounds reasonable to me