Re: [PATCH v2 2/2] clk: qcom: Add support for Global Clock Controller on QCS8300

From: Andrew Lunn
Date: Thu Aug 22 2024 - 16:00:13 EST


> +static int gcc_qcs8300_probe(struct platform_device *pdev)
> +{
> + struct regmap *regmap;
> + int ret;
> +
> + regmap = qcom_cc_map(pdev, &gcc_qcs8300_desc);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + ret = qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks,
> + ARRAY_SIZE(gcc_dfs_clocks));
> + if (ret)
> + return ret;
> +
> + /* Keep some clocks always enabled */

Sorry, but you need to explain why. Why cannot the camera driver
enable these clocks when it loads? Why cannot the display driver
enable these clocks when it loads.

Andrew