Re: [PATCH] Staging: rtl8192e: Fix arguments alignment

[Ana Carolina H.]

On Thu, Aug 22, 2024 at 4:53 AM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Aug 21, 2024 at 09:30:43PM -0300, Ana Carolina Hernandes wrote:
> > Fix the alignment of arguments in function _rtl92e_query_rxphystatus in
> > order to silence the following checkpatch warning:
> >
> > CHECK: Lines should not end with a '('
> >
> > Signed-off-by: Ana Carolina Hernandes <anachan.01h@xxxxxxxxx>
> > ---
> >  .../staging/rtl8192e/rtl8192e/r8192E_dev.c    | 19 +++++++++----------
> >  1 file changed, 9 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> > index b3d4b3394284..bca6e4f57bf2 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> > @@ -1145,16 +1145,15 @@ static long _rtl92e_signal_scale_mapping(struct r8192_priv *priv, long currsig)
> >                       _pdrvinfo->RxRate == DESC90_RATE11M) &&\
> >                       !_pdrvinfo->RxHT)
> >
> > -static void _rtl92e_query_rxphystatus(
> > -     struct r8192_priv *priv,
> > -     struct rtllib_rx_stats *pstats,
> > -     struct rx_desc  *pdesc,
> > -     struct rx_fwinfo   *pdrvinfo,
> > -     struct rtllib_rx_stats *precord_stats,
> > -     bool bpacket_match_bssid,
> > -     bool bpacket_toself,
> > -     bool bPacketBeacon,
> > -     bool bToSelfBA
> > +static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
> > +                                   struct rtllib_rx_stats *pstats,
> > +                                   struct rx_desc  *pdesc,
> > +                                   struct rx_fwinfo   *pdrvinfo,
> > +                                   struct rtllib_rx_stats *precord_stats,
> > +                                   bool bpacket_match_bssid,
> > +                                   bool bpacket_toself,
> > +                                   bool bPacketBeacon,
> > +                                   bool bToSelfBA
> >       )
>
> So close, why leave the ")" on the line all by itself there?  It needs
> to go up one line, didn't checkpatch tell you that when you ran it on
> this change?
>
> thanks,
>
> greg k-h

Checkpatch didn't warn me about the ")", but I will fix it too.

Thanks,
Ana Carolina Hernandes