Re: [PATCH v2] ata: pata_macio: Use WARN instead of BUG
From: Sergei Shtylyov
Date: Thu Aug 22 2024 - 16:39:35 EST
On 8/22/24 5:59 AM, Christoph Hellwig wrote:
[...]
>>> The overflow/underflow conditions in pata_macio_qc_prep() should never
>>> happen. But if they do there's no need to kill the system entirely, a
>>> WARN and failing the IO request should be sufficient and might allow the
>>> system to keep running.
>>
>> WARN*() can kill your system with panic_on_warn -- Android is particularly
>> fond of this kernel parameter but I guess it's not your case... :-)
>> Greg KH usually advices against using these macros. :-)
>
> And in this case he is simply totally wrong. The whole poing of WARN_ON
Greg does have a point: on billions of Linux systems (Android phones) that
all use panic_on_warn=1, WARN*() is pretty much equivalent to panic()... :-/
> is to have a standardized way to assert conditions.
Hm, makes me remember assert() in C aborts a program... :-)
MBR, Sergey