Re: [PATCH] leds: gpio: Set num_leds after allocation

[Kees Cook]

On Thu, Jul 25, 2024 at 11:22:40AM +0100, Lee Jones wrote:
> On Tue, 16 Jul 2024, Gustavo A. R. Silva wrote:
> 
> > 
> > 
> > On 16/07/24 15:24, Kees Cook wrote:
> > > With the new __counted_by annotation, the "num_leds" variable needs to
> > > valid for accesses to the "leds" array. This requirement is not met in
> > > gpio_leds_create(), since "num_leds" starts at "0", so "leds" index "0"
> > > will not be considered valid (num_leds would need to be "1" to access
> > > index "0").
> > > 
> > > Fix this by setting the allocation size after allocation, and then update
> > > the final count based on how many were actually added to the array.
> > > 
> > > Fixes: 52cd75108a42 ("leds: gpio: Annotate struct gpio_leds_priv with __counted_by")
> > > Signed-off-by: Kees Cook <kees@xxxxxxxxxx>
> > 
> > Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > 
> > Thanks
> > -- 
> 
> Using the signature tag in the middle of an email turns the remainder of
> the body into a signature block, which is odd to say the least.  By all
> means sign-off in the middle of a mail, but please refrain from
> converting the rest of the mail.

Ping. Shall I take this via the hardening tree?

-Kees

-- 
Kees Cook