Re: [PATCH v3] Documentation: KUnit: Update filename best practices
From: Kees Cook
Date: Thu Aug 22 2024 - 20:18:36 EST
On Fri, Jul 26, 2024 at 03:14:36PM +0800, David Gow wrote:
> On Thu, 25 Jul 2024 at 04:14, Kees Cook <kees@xxxxxxxxxx> wrote:
> >
> > Based on feedback from Linus[1] and follow-up discussions, change the
> > suggested file naming for KUnit tests.
> >
> > Link: https://lore.kernel.org/lkml/CAHk-=wgim6pNiGTBMhP8Kd3tsB7_JTAuvNJ=XYd3wPvvk=OHog@xxxxxxxxxxxxxx/ [1]
> > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
> > Signed-off-by: Kees Cook <kees@xxxxxxxxxx>
> > ---
>
> Looks good to me. (And it seems like sphinx is okay with it, too,
> which is always nice.)
>
> We normally take these changes in via the kunit tree, but if you want
> to try to push it through along with the naming changes, that's fine
> by me.
>
> Reviewed-by: David Gow <davidgow@xxxxxxxxxx>
Hi! Just a quick check: I haven't seen this land in -next yet. Are you
still planning to take this?
--
Kees Cook