Re: [PATCH 0/3] cpufreq/amd-pstate: A set of fixes

From: Gautham R. Shenoy
Date: Fri Aug 23 2024 - 00:13:42 EST


Hello Mario,


On Thu, Aug 22, 2024 at 03:41:30PM -0500, Mario Limonciello wrote:
> On 8/13/2024 04:51, Gautham R. Shenoy wrote:
> > Hello Rafael, Viresh,
> >
> > This series contains three fixes for the amd-pstate driver for 6.11.
> > Could you please include it in your tree?
> >
> > These patches are based on linux-pm/master with the top commit
> > 7c626ce4bae1 ("Linux 6.11-rc3").
> >
> > There are three patches,
> >
> > 1. To fix an uninitialized variable in amd_pstate_cpu_boost_update()
> > from Dan Carpenter:
> > https://lore.kernel.org/lkml/7ff53543-6c04-48a0-8d99-7dc010b93b3a@stanley.mountain/
> >
> > 2. Use topology_logical_package_id() instead of
> > topology_logical_die_id() definition of the later function has
> > changed on some AMD processors since the inclusion of the CPUID
> > 0x80000026 parser:
> > https://lore.kernel.org/lkml/20240801124509.3650-1-Dhananjay.Ugwekar@xxxxxxx/
> >
> > 3. Remove a warning for the absence fo X86_FEATURE_CPPC on Zen1 and
> > Zen2 since they don't have the feature defined. This fixes the
> > regression reported by David Wang:
> > https://lore.kernel.org/lkml/20240730140111.4491-1-00107082@xxxxxxx/

> >
> > Thanks and Regards
> > gautham.
> >
> > Dan Carpenter (1):
> > cpufreq: amd-pstate: Fix uninitialized variable in
> > amd_pstate_cpu_boost_update()
> >
> > Gautham R. Shenoy (2):
> > cpufreq/amd-pstate: Use topology_logical_package_id() instead of
> > logical_die_id()
> > cpufreq/amd-pstate: Remove warning for X86_FEATURE_CPPC on Zen1 and
> > Zen2
> >
> > drivers/cpufreq/amd-pstate.c | 10 ++++------
> > 1 file changed, 4 insertions(+), 6 deletions(-)
> >
>
> Thanks for handling these. I'm back now, I'm digging through my inbox.
> Assuming Rafael didn't already pull these I'll batch these into my
> amd-pstate branch for the robots to bang on and then send a PR after I go
> through everything else that happened.

Thank you Mario. I will be sending an updated version to Patch 3
"Remove warning for X86_FEATURE_CPPC on Zen1 and Zen2" to incorporate
feedback from Xiaojian.

Please merge the Patches 1 and 2 from this series.

--
Thanks and Regards
gautham.