Re: [PATCH v2 01/16] dt-bindings: dma: qcom,bam: Add bam pipe lock
From: Manivannan Sadhasivam
Date: Fri Aug 23 2024 - 11:43:48 EST
On Thu, Aug 15, 2024 at 02:27:10PM +0530, Md Sadre Alam wrote:
> BAM having pipe locking mechanism. The Lock and Un-Lock bit
> should be set on CMD descriptor only. Upon encountering a
> descriptor with Lock bit set, the BAM will lock all other
> pipes not related to the current pipe group, and keep
> handling the current pipe only until it sees the Un-Lock
> set.
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx>
> ---
>
> Change in [v2]
>
> * Added initial support for dt-binding
>
> Change in [v1]
>
> * This patch was not included in [v1]
>
> Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> index 3ad0d9b1fbc5..91cc2942aa62 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> @@ -77,6 +77,12 @@ properties:
> Indicates that the bam is powered up by a remote processor but must be
> initialized by the local processor.
>
> + qcom,bam_pipe_lock:
> + type: boolean
> + description:
> + Indicates that the bam pipe needs locking or not based on client driver
> + sending the LOCK or UNLOK bit set on command descriptor.
> +
This looks like a pure driver implementation and doesn't belong to the DT at
all. Why can't you add a logic in the driver to use the lock based on some
detection mechanism?
- Mani
> reg:
> maxItems: 1
>
> @@ -92,6 +98,8 @@ anyOf:
> - qcom,powered-remotely
> - required:
> - qcom,controlled-remotely
> + - required:
> + - qcom,bam_pipe_lock
> - required:
> - clocks
> - clock-names
> --
> 2.34.1
>
>
--
மணிவண்ணன் சதாசிவம்