Re: [PATCHv2 net-next] net: ag71xx: add missing reset_control_put

[Rosen Penev]

On Fri, Aug 23, 2024 at 9:48 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> Hi Rosen,
>
> On Fri, Aug 23, 2024 at 01:04:18PM -0700, Rosen Penev wrote:
> > The original downstream driver used devm instead of of. The latter
> > requires reset_control_put to be called in all return paths.
>
> At the moment of upstreaming this code, the original driver used
> of_reset_control_get_exclusive() and was fixed by f92bbdcc93 ("ath79:
> ag71xx-mdio: get reset control using devm api")
>
> Why not port the original fix?
On further review, this looks safe to do. Will submit tomorrow.
>
> Regards,
> Oleksij
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |