Re: [PATCH] staging: rtl8192e: Replace strcpy with strscpy in rtl819x_translate_scan

From: Christophe JAILLET
Date: Sat Aug 24 2024 - 02:35:20 EST


Le 21/08/2024 à 20:23, Dan Carpenter a écrit :
On Tue, Aug 20, 2024 at 09:38:22PM +0200, Christophe JAILLET wrote:
- if a "mode" matches, do we need to iterate the whole rtllib_modes
array? (have a look at wireless_mode)


Can only one mode be set at a time?

regards,
dan carpenter




Hmm, apparently several can be set (see [1])

Base on a few lines below, it looks that WIRELESS_MODE_N_24G is exclusive from the other ones.

So the 6 char array seems to be sized either for "N-24G", either for a concatenation of a few other modes that won't exceed the size of the buffer.

CJ


[1]: https://elixir.bootlin.com/linux/v6.11-rc4/source/drivers/staging/rtl8192e/rtllib_rx.c#L2200