Re: [PATCH v3 1/2] PCI: don't rely on of_platform_depopulate() for reused OF-nodes

From: Bartosz Golaszewski
Date: Sat Aug 24 2024 - 03:49:39 EST


On Sat, Aug 24, 2024 at 12:10 AM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> [+to Rob]
>
> On Fri, Aug 23, 2024 at 11:33:22AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > of_platform_depopulate() doesn't play nice with reused OF nodes - it
> > ignores the ones that are not marked explicitly as populated and it may
> > happen that the PCI device goes away before the platform device in which
> > case the PCI core clears the OF_POPULATED bit. We need to
> > unconditionally unregister the platform devices for child nodes when
> > stopping the PCI device.
>
> Rob, any concerns with this?
>

If there will be any concerns: I'm OoO next week so I'll only be able
to address them on September 2nd.

Bart