Re: [PATCH v2] X86 architecture (32-bit and 64-bit): Convert to use jiffies macro

From: Thomas Gleixner
Date: Sun Aug 25 2024 - 07:24:04 EST


On Thu, Aug 22 2024 at 16:24, Chen Yufan wrote:
> Use time_after macro instead of using
> jiffies directly to handle wraparound.
>
> Signed-off-by: Chen Yufan <chenyufan@xxxxxxxx>
>
> The modifications made compared to the previous version are as follows:

Please put such version information below the --- separator so tools can
strip it off when applying the patch, which avoids editiong

> 1. Remove extra '+' in the header.

The subject line still has a incorrect subsystem prefix:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

Also 'use jiffies macro' is not really informative. Something like

"Use time_after() for jiffies comparison"

makes it entirely clear what this is about.

> Use time_after macro instead of using
> jiffies directly to handle wraparound.

Also here instead of 'time_after macro' please use simply
'time_after()'. It's uninteresting whether this is a macro or not.

Thanks,

tglx