Re: [PATCH] Revert "memory: ti-aemif: don't needlessly iterate over child nodes"

From: Krzysztof Kozlowski
Date: Sun Aug 25 2024 - 08:23:01 EST



On Sat, 24 Aug 2024 10:02:35 +0200, Bartosz Golaszewski wrote:
> This reverts commit 23a641d5c2bce4c723fff9118a5d865ee6b9d05a.
>
> The first-level children of the aemif node are not the device nodes (ones
> containing the 'compatible' property) but the chip-select nodes which
> instead have their own children.
>
> of_platform_populate() will skip such nodes so we must indeed iterate
> over the direct children of the aemif node. The problem here is that we
> never call of_platform_depopulate() as it takes the root device as
> argument. We only have an unpopulated chip-select nodes so we will leak
> these devices if any of the calls to of_platform_populate() fails.
>
> [...]

Applied, thanks!

[1/1] Revert "memory: ti-aemif: don't needlessly iterate over child nodes"
https://git.kernel.org/krzk/linux-mem-ctrl/c/c7d2f3fbdf59b206414ddc306b0fb74cd174c0ed

Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>