Re: [PATCH 5.15 000/479] 5.15.165-rc3 review

[Guenter Roeck]

On 8/17/24 01:00, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.165 release.
> There are 479 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Mon, 19 Aug 2024 07:51:05 +0000.
> Anything received after that time might be too late.
[ ... ]
> Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
>      MIPS: Loongson64: reset: Prioritise firmware service

This patch in v5.15.165 results in:

Building mips:loongson2k_defconfig ... failed
--------------
Error log:
arch/mips/loongson64/reset.c:25:36: error: 'struct sys_off_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
   25 | static int firmware_restart(struct sys_off_data *unusedd)
      |                                    ^~~~~~~~~~~~
arch/mips/loongson64/reset.c:34:37: error: 'struct sys_off_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
   34 | static int firmware_poweroff(struct sys_off_data *unused)
      |                                     ^~~~~~~~~~~~
arch/mips/loongson64/reset.c: In function 'mips_reboot_setup':
arch/mips/loongson64/reset.c:144:17: error: implicit declaration of function 'register_sys_off_handler'; did you mean 'register_restart_handler'? [-Werror=implicit-function-declaration]
  144 |                 register_sys_off_handler(SYS_OFF_MODE_RESTART,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~
      |                 register_restart_handler
arch/mips/loongson64/reset.c:144:42: error: 'SYS_OFF_MODE_RESTART' undeclared (first use in this function)
  144 |                 register_sys_off_handler(SYS_OFF_MODE_RESTART,
      |                                          ^~~~~~~~~~~~~~~~~~~~
arch/mips/loongson64/reset.c:144:42: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/loongson64/reset.c:145:34: error: 'SYS_OFF_PRIO_FIRMWARE' undeclared (first use in this function)
  145 |                                  SYS_OFF_PRIO_FIRMWARE,
      |                                  ^~~~~~~~~~~~~~~~~~~~~
arch/mips/loongson64/reset.c:150:42: error: 'SYS_OFF_MODE_POWER_OFF' undeclared (first use in this function); did you mean 'SYSTEM_POWER_OFF'?
  150 |                 register_sys_off_handler(SYS_OFF_MODE_POWER_OFF,
      |                                          ^~~~~~~~~~~~~~~~~~~~~~
      |                                          SYSTEM_POWER_OFF

This is not entirely surprising since the missing functions and defines
do not exist in v5.15.y.

Guenter