Re: [PATCH v3 3/3] LoongArch: Update dts to support Loongson UART driver.

[Krzysztof Kozlowski]

On 26/08/2024 08:54, 郑豪威 wrote:
> 
> 在 2024/8/26 14:00, Krzysztof Kozlowski 写道:
>> On Mon, Aug 26, 2024 at 10:47:05AM +0800,zhenghaowei@xxxxxxxxxxx wrote:
>>> From: Haowei Zheng<zhenghaowei@xxxxxxxxxxx>
>>>
>>> Change to use the Loongson UART driver for Loongson-2K2000,
>>> Loongson-2K1000 and Loongson-2K0500.
>> Why?
>>
>> That's what commit msg should explain.  This is not bisectable and
>> breaks users without any reasonable need/explanation.
>>
>> Best regards,
>> Krzysztof
> 
> I got it, and I will provide detailed explanations like this:
> 
> We have provided separate UART drivers for ls2k0500,  ls2k1000, and
> 
> ls2k2000, which solves the issue of the full-featured serial port being
> 
> unusable. Additionally, we have implemented fractional division
> 
> functionality for ls2k2000.

You still break the users. Explain the problem you are fixing. NAK.

Best regards,
Krzysztof