Re: [PATCH] ALSA: hda: hda_component: Fix mutex crash if nothing ever binds

[Takashi Iwai]

On Mon, 26 Aug 2024 11:49:40 +0200,
Richard Fitzgerald wrote:
> 
> Move the initialization of parent->mutex into
> hda_component_manager_init() so that it is always valid.
> 
> In hda_component_manager_bind() do not clear the parent information.
> Only zero-fill the per-component data ready for it to be filled in
> by the components as they bind.
> 
> Previously parent->mutex was being initialized only in
> hda_component_manager_bind(). This meant that it was only
> initialized if all components appeared and there was a bind callback.
> If there wasn't a bind the mutex object was not valid when the
> Realtek driver called any of the other functions.
> 
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> Fixes: 047b9cbbaa8e ("ALSA: hda: hda_component: Protect shared data with a mutex")

Thanks, applied now to for-linus branch.


Takashi